Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodshad"post", which never matchedc.req.method("POST"). Changed it to"POST".User.userNametousernameto match the db, the routes and the tests.badRequestimport. Its absence caused a ReferenceError, so the endpoint returned 500 instead of 400.paginateto the contract in the test."types": ["bun-types"], which resolves thebun:testandprocesserrors.bun-typesis already installed.Verification
bun testpasses 22/22, with 0 failures.tsc --noEmitreports no errors.Assumptions / review notes
POST /usersandPOST /posts. That is the policy documented inauth.tsand asserted byauth.test.ts, so I kept it to stay within "don't modify tests". It does let anyone create users, and create posts under anyauthorId. Any new POST route will also be public by default. Consider allowing specific route+method pairs instead.process.env.API_TOKEN ?? "test-token"falls back to a hardcoded token whenAPI_TOKENis unset. It should fail closed instead.paginatedoes not validatepage < 1orsize <= 0, because the tests don't require it.